[Kde-games-devel] Review Request 122973: [ksirk frameworks] Main function (--kdelibs4support)

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122973/#review77543
-----------------------------------------------------------



ksirk/main.cpp
<https://git.reviewboard.kde.org/r/122973/#comment53259>

    Please don't create static variable. Assign directly.



ksirk/main.cpp
<https://git.reviewboard.kde.org/r/122973/#comment53260>

    Please keep kdebug=> convert it to qDebug.


- Laurent Montel


On mars 15, 2015, 10:47 après-midi, Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122973/
> -----------------------------------------------------------
> 
> (Updated mars 15, 2015, 10:47 après-midi)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksirk
> 
> 
> Description
> -------
> 
> Replace K4AboutData with KAboutData, 
> Replace KCmdLineOptions with QCommandLineParser, 
> Use QApplication instead of KApplication, 
> Clean unused header files, 
> Remove not used cmd line argument, 
> Remove kdebug (not needed here)
> 
> 
> Diffs
> -----
> 
>   ksirk/main.cpp 4a9101b 
> 
> Diff: https://git.reviewboard.kde.org/r/122973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150316/f1fb83b6/attachment.html>