[Kde-games-devel] Review Request 122869: add high DPI support to declarative games

[David Edmundson]

> On March 9, 2015, 11:21 p.m., Albert Astals Cid wrote:
> > kgthemeprovider.cpp, line 286
> > <https://git.reviewboard.kde.org/r/122869/diff/1/?file=353876#file353876line286>
> >
> >     Why are you checking for Qt::AA_UseHighDpiPixmaps here but not in the code above?

Good question, I'll add some comments in the code explaining.

When returning pixmaps I need to rely on the calling application being able to handle surpringly sized pixmaps. I know knetwalk was fine, but it makes it safer for every other users of the lib, just in case it uses the returned pixmap in a "wrong" way in some other QPainter code. 
They need to add this attribute to get high DPR pixmaps from QIcon anyway.

>From the imageprovider I know it can only be used from QtQuick inside an Image item, so it's always going to do the right thing.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122869/#review77238
-----------------------------------------------------------


On March 9, 2015, 12:17 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122869/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 12:17 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Made everything needed for KNetwalk to work with QT_DEVICE_PIXEL_RATIO=2
> 
> 
> Diffs
> -----
> 
>   kgimageprovider.cpp 4a46ddc 
>   kgthemeprovider.cpp 37be33e 
> 
> Diff: https://git.reviewboard.kde.org/r/122869/diff/
> 
> 
> Testing
> -------
> 
> Ran KNetwalk with QT_DEVICE_PIXEL_RATIO=2 everything was super smooth.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150309/f08a7785/attachment.html>