[Kde-games-devel] Review Request 124392: Remove KExtHighscore classes

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124392/
-----------------------------------------------------------

(Updated July 20, 2015, 5:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Changes
-------

Submitted with commit 75454239b5ecd9841c1f9427990a9782aa11bf8d by Albert Astals Cid to branch master.


Repository: libkdegames


Description
-------

They are deorecated, complex, unmaintained and offer lots of functionality we don't use and prefer to not maintain.

The classes were also unfinished porting since kreversi is the only user and there's still no KF5 version of it.

Also they are the last source of kdelibs4support in libkdegames so that's a plus.

The only known user of KExtHighscore is kreversi, see https://git.reviewboard.kde.org/r/124393/ for the review request that adds the files there.


Diffs
-----

  CMakeLists.txt 3c211f3 
  KDEGamesConfig.cmake.in 361dbf8 
  highscore/CMakeLists.txt eecb85e 
  highscore/kexthighscore.cpp 3367326 
  highscore/kexthighscore_gui.h 4e8c0fa 
  highscore/kexthighscore_gui.cpp d5dba12 
  highscore/kexthighscore_internal.h 40f301c 
  highscore/kexthighscore_internal.cpp 0bcc62d 
  highscore/kexthighscore_item.h 51c29c5 
  highscore/kexthighscore_item.cpp 9efb069 
  highscore/kexthighscore_tab.h cc96d10 
  highscore/kexthighscore_tab.cpp e6e616b 

Diff: https://git.reviewboard.kde.org/r/124392/diff/


Testing
-------


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150720/f13458a3/attachment.html>