<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124392/">https://git.reviewboard.kde.org/r/124392/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated July 20, 2015, 5:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 75454239b5ecd9841c1f9427990a9782aa11bf8d by Albert Astals Cid to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkdegames
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">They are deorecated, complex, unmaintained and offer lots of functionality we don't use and prefer to not maintain.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The classes were also unfinished porting since kreversi is the only user and there's still no KF5 version of it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also they are the last source of kdelibs4support in libkdegames so that's a plus.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only known user of KExtHighscore is kreversi, see https://git.reviewboard.kde.org/r/124393/ for the review request that adds the files there.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3c211f3)</span></li>
<li>KDEGamesConfig.cmake.in <span style="color: grey">(361dbf8)</span></li>
<li>highscore/CMakeLists.txt <span style="color: grey">(eecb85e)</span></li>
<li>highscore/kexthighscore.cpp <span style="color: grey">(3367326)</span></li>
<li>highscore/kexthighscore_gui.h <span style="color: grey">(4e8c0fa)</span></li>
<li>highscore/kexthighscore_gui.cpp <span style="color: grey">(d5dba12)</span></li>
<li>highscore/kexthighscore_internal.h <span style="color: grey">(40f301c)</span></li>
<li>highscore/kexthighscore_internal.cpp <span style="color: grey">(0bcc62d)</span></li>
<li>highscore/kexthighscore_item.h <span style="color: grey">(51c29c5)</span></li>
<li>highscore/kexthighscore_item.cpp <span style="color: grey">(9efb069)</span></li>
<li>highscore/kexthighscore_tab.h <span style="color: grey">(cc96d10)</span></li>
<li>highscore/kexthighscore_tab.cpp <span style="color: grey">(e6e616b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124392/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>