[Kde-games-devel] OSX/CI: ksudoku fails to build on branch master

[Ian Wadham]

On 21/01/2015, at 7:27 PM, laurent Montel wrote:
> Le Wednesday 21 January 2015 09:12:27 Marko Käning a écrit :
>> On 21 Jan 2015, at 04:44 , Ian Wadham <iandw.au at gmail.com> wrote:
>>> Maybe this is failing because Q_WS_MAC is no longer defined in Qt 5?  Try
>>> Q_OS_MAC --- or something else?
>> 
>> that was it! Committed for ksudoku in
>> 
>> 	http://commits.kde.org/ksudoku/1f9c2983137d7b83c4496e3fafce703b5ef19987
>> 
>> :-)
>> :
>>> If it works, kubrick and ksudoku repositories will BOTH need to be
>>> changed,
>>> on the frameworks branch.
>> 
>> Well, and for kubrick is is here
>> 
>> 	http://commits.kde.org/kubrick/c8a4cf1d017306f141ce179f5008e9bb981752f4
>> 
>> :-)
>> 
>> P.S.: It seems to make sense to grep for this invalid define in all KF5
>> projects... 
> 
> Indeed my script didn't convert it.
> I fixed remove-kde4support.pl for it.

Thanks, Laurent.

Marko Käning found some occurrences of the obsolete Q_OS_MAC[X]* macros
in other KF5 projects and says he has now fixed them.

René Bertin found some in Qt 5 itself and has raised the topic on the
Qt interest list.

I also think there may be some occurrences in Frameworks libraries and
have asked Marko to have a look.  There are some in kdelibs, but I hope
they have been ported away in Frameworks.

For your interest as a core developer, Laurent…

Cheers, Ian W.