[Kde-games-devel] Review Request 122710: migrate old data to new XDG_DATA_DIR location

[Mathias Kraus]

> On Feb. 24, 2015, 8:29 p.m., Laurent Montel wrote:
> > src/main.cpp, line 34
> > <https://git.reviewboard.kde.org/r/122710/diff/1/?file=351502#file351502line34>
> >
> >     Why ?
> >     kdelibs4migrator does it for you

migrate() seems to return always true, even if the config file is already migrated


> On Feb. 24, 2015, 8:29 p.m., Laurent Montel wrote:
> > src/main.cpp, line 68
> > <https://git.reviewboard.kde.org/r/122710/diff/1/?file=351502#file351502line68>
> >
> >     Better to put it on top

As I already wrote in the description. If it is on top, the migrated settings are not used on the first run and if the user opens the config dialog, the default values are loaded, resulting in a lost configuration if the user changes something and saves the changes. That's at least the experience I had.


- Mathias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122710/#review76566
-----------------------------------------------------------


On Feb. 24, 2015, 8:22 p.m., Mathias Kraus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122710/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 8:22 p.m.)
> 
> 
> Review request for KDE Games and Laurent Montel.
> 
> 
> Repository: granatier
> 
> 
> Description
> -------
> 
> I'm not sure if this is correct. If QApplication is created before the migration, the data gets migrated, but the migrated settings and data are not used on the first run, only on the second. If the user open the config dialog at the first run, the default values are loaded and if the user does some changes and saves the changes, the old config will be overwritten.
> If QApplication is created after the migration, the settings and data are used at the first run.
> 
> 
> Diffs
> -----
> 
>   src/main.cpp ab7cf2a 
> 
> Diff: https://git.reviewboard.kde.org/r/122710/diff/
> 
> 
> Testing
> -------
> 
> data are migrated on the first run
> 
> 
> Thanks,
> 
> Mathias Kraus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150224/50f36af9/attachment-0001.html>