[Kde-games-devel] Review Request 122710: migrate old data to new XDG_DATA_DIR location

Laurent Montel montel at kde.org
Tue Feb 24 20:29:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122710/#review76566
-----------------------------------------------------------



src/main.cpp
<https://git.reviewboard.kde.org/r/122710/#comment52736>

    Why ?
    kdelibs4migrator does it for you



src/main.cpp
<https://git.reviewboard.kde.org/r/122710/#comment52737>

    Better to put it on top


- Laurent Montel


On fév. 24, 2015, 8:22 après-midi, Mathias Kraus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122710/
> -----------------------------------------------------------
> 
> (Updated fév. 24, 2015, 8:22 après-midi)
> 
> 
> Review request for KDE Games and Laurent Montel.
> 
> 
> Repository: granatier
> 
> 
> Description
> -------
> 
> I'm not sure if this is correct. If QApplication is created before the migration, the data gets migrated, but the migrated settings and data are not used on the first run, only on the second. If the user open the config dialog at the first run, the default values are loaded and if the user does some changes and saves the changes, the old config will be overwritten.
> If QApplication is created after the migration, the settings and data are used at the first run.
> 
> 
> Diffs
> -----
> 
>   src/main.cpp ab7cf2a 
> 
> Diff: https://git.reviewboard.kde.org/r/122710/diff/
> 
> 
> Testing
> -------
> 
> data are migrated on the first run
> 
> 
> Thanks,
> 
> Mathias Kraus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150224/c7b8abbc/attachment.html>


More information about the kde-games-devel mailing list