[Kde-games-devel] Review Request 122211: [libkdegames] Make tests optional

Sat Feb 7 18:49:40 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122211/
-----------------------------------------------------------

(Updated Feb. 7, 2015, 6:49 p.m.)

Review request for KDE Games.

Changes
-------

Rev.2: Only touch root CMakeLists.txt, an approach that found more approval as seen in kwin

Repository: libkdegames

Description (updated)
-------

Qt5Test should not be mandatory, ~~patch to add tests subdirs only if BUILD_TESTING and moved find_package(Qt5Test...) into the respective tests CMakeLists.txt~~

I should add that I don't have write access, so I ask for someone else to merge it.

Diffs (updated)
-----

  CMakeLists.txt 2664fd4ea3234bfe6f9c7d4062579e91adc163fe 

Diff: https://git.reviewboard.kde.org/r/122211/diff/

Testing
-------

Built with and without tests.

Thanks,

Andreas Sturmlechner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150207/9c255004/attachment.html>