[Kde-games-devel] Review Request 122211: [libkdegames] Make tests optional

[Andreas Sturmlechner]

> On Jan. 22, 2015, 9:10 p.m., Albert Astals Cid wrote:
> > I disagree with this. What's your rationale for making the cmake code more complex?
> 
> Andreas Sturmlechner wrote:
>     Well, the same could be achieved with fewer lines:
>     Put find_package(Qt5Test...) behind if(BUILD_TESTING) in the root CMakeLists.txt, that would remove the need to patch the tests subdirs.
>     
>     Do you disagree with making Qt5Test optional in principle or shall I go the simpler route?
> 
> Albert Astals Cid wrote:
>     Note i'm not the maintainer so me disagreeing doesn't mean someone will pick it up and commit it.
>     
>     I disagree since i don't see the benefit and to me tests are an integral part of the code.

As for my rationale, I'd like to refer to previous discussions that resulted in favor of making tests optional: https://git.reviewboard.kde.org/r/117393/

Tests are important to developers and packagers, but users of source packages should not be forced to build the tests all the time. This is especially the case when pulling from git, where tests might hang or there is no (often required) X available at build time.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122211/#review74564
-----------------------------------------------------------


On Jan. 22, 2015, 9:06 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122211/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 9:06 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Qt5Test should not be mandatory, patch to add tests subdirs only if BUILD_TESTING and moved find_package(Qt5Test...) into the respective tests CMakeLists.txt
> 
> I should add that I don't have write access, so I ask for someone else to merge it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2664fd4ea3234bfe6f9c7d4062579e91adc163fe 
>   libkdegamesprivate/CMakeLists.txt b122f37abe1b403042c347c5ad4ff5d37e3dffba 
>   libkdegamesprivate/tests/CMakeLists.txt 59ac2b4be7d35eb9518d277379ad53a7f00e5171 
>   tests/CMakeLists.txt 7b95e60cd11119b745e8c6830f1514a61fb0c6e1 
> 
> Diff: https://git.reviewboard.kde.org/r/122211/diff/
> 
> 
> Testing
> -------
> 
> Built with and without tests.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150201/493010c2/attachment.html>