[Kde-games-devel] Review Request 121816: Reduce redrawing of game board

[Ian Wadham]

> On Nov. 11, 2015, 8:44 a.m., Frederik Schwarzer wrote:
> > Ping.

The diffs for this change will be obsolete when we switch to using Qt's QGraphicsView library classes in KMahjongg.  In particular, there will be no BoardWidget code any more.  The intent of the change is good, however, and it should be re-implemented in the frameworks (KF5) version of KMahjongg after it has been merged into the master branch, but using QGraphicsView-style coding this time.

Other patches contributed to KMahjongg by Jan-Peter Nilsson will also need to be reviewed. Some will be already addressed by the QGV code, some will need to be re-implemented, etc.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121816/#review88242
-----------------------------------------------------------


On July 12, 2015, 2:30 p.m., Jan-Peter Nilsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121816/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 2:30 p.m.)
> 
> 
> Review request for KDE Games and Ian Wadham.
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> Do not redraw the entire game board including background unless
> required due to a change of background or resize of the window.
> 
> 
> Diffs
> -----
> 
>   boardwidget.h 6e1d3f5 
>   boardwidget.cpp 6a4f033 
>   kmahjongg.h 3a101fc 
>   kmahjongg.cpp eb1dfa1 
> 
> Diff: https://git.reviewboard.kde.org/r/121816/diff/
> 
> 
> Testing
> -------
> 
> - Shuffle (does not redraw background anymore)
> - New game (does not redraw background anymore)
> - Change background in settings (redraws the background)
> - Changing layout in settings (Create new game with the new layout, do not redraw background)
> - Changing tileset in settings (Recreate tileset, do not redraw background)
> - Load saved game with different background (redraws the background)
> - Resize the window (redraws the background)
> 
> 
> Thanks,
> 
> Jan-Peter Nilsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151219/b302fe07/attachment.html>