[Kde-games-devel] Review Request 123328: Some fixes for OSX

[Minh Ngo]

> On apr 11, 2015, 9:30 a.m., Minh Ngo wrote:
> > Ship It!
> 
> Marko Käning wrote:
>     Hey, we cannot ship, I am afraid, as this is not yet generating an OSX application package as it should.
>     
>     We're still missing something to get that to work...
> 
> Marko Käning wrote:
>     Also, I don't find code for the application icon (yet).
>     
>     E.g. kapman does this:
>     ```
>     ecm_install_icons(ICONS 128-apps-kapman.png  16-apps-kapman.png  22-apps-kapman.png  32-apps-kapman.png  48-apps-kapman.png  64-apps-kapman.png DESTINATION ${KDE_INSTALL_ICONDIR} THEME hicolor)
>     
>     file(GLOB ICONS_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/*-apps-kapman.png")
>     ecm_add_app_icon(kapman_SRCS ICONS ${ICONS_SRCS})
>     ```
> 
> Marko Käning wrote:
>     ah, ok there is ecm_install_icons() in ./pictures/CMakeLists.txt...
> 
> Minh Ngo wrote:
>     Ok, so let's wait for Ian's review then, because I don't have a Mac to check (previously you have removed him from reviewers list).
> 
> Marko Käning wrote:
>     Can you test building with this patch on Linux, Minh?

Regarding to your last changes. In Linux it generates plugins with a prefix libkdots_* ( http://build.kde.org/job/kdots_master_qt5/8/console ) and in my code I'm trying to look for this prefix. It can be a reason why plugins cannot be found in Mac.

Can you try to change it for Mac here? http://quickgit.kde.org/?p=kdots.git&a=blob&h=d983ae240aad354e8db33e34c72fa3d41f8ef029&hb=e7fdd108b8c078ad864df7581a28d75adfb82327&f=kdotslib%2Fconstants.hpp


- Minh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123328/#review78789
-----------------------------------------------------------


On apr 11, 2015, 10:51 a.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123328/
> -----------------------------------------------------------
> 
> (Updated apr 11, 2015, 10:51 a.m.)
> 
> 
> Review request for KDE Games, Ian Wadham and Minh Ngo.
> 
> 
> Repository: kdots
> 
> 
> Description
> -------
> 
> Hi Minh,
> 
> I've added a RB config as well as introduced some changes re std:abs() specific to OSX. Also I added a forgotten include.
> 
> There's another issue to be fixed, but I'll post this to the mailing list independently.
> 
> Greets,
> Marko
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   CMakeLists.txt 81b1273bee0f5c930ec350edfd2030150b053ee1 
>   kdotslib/polygon.hpp dca4b55594372be7db96e92f11dc8af39052ce1e 
>   kdotslib/polygon.cpp ace662d08b4984dc87744acebebe7f7c26172a97 
>   kdotslib/stepqueue.hpp 2ff853e558e69ba31122245b1bdb5cd240e45afb 
>   pictures/CMakeLists.txt 90cebc068fe4a85b8370368fbebc8ec597412af7 
> 
> Diff: https://git.reviewboard.kde.org/r/123328/diff/
> 
> 
> Testing
> -------
> 
> Builds now also on OSX.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150411/3145616a/attachment-0001.html>