<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123328/">https://git.reviewboard.kde.org/r/123328/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On april 11th, 2015, 9:30 a.m. UTC, <b>Minh Ngo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On april 11th, 2015, 9:32 a.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hey, we cannot ship, I am afraid, as this is not yet generating an OSX application package as it should.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We're still missing something to get that to work...</p></pre>
</blockquote>
<p>On april 11th, 2015, 9:35 a.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, I don't find code for the application icon (yet).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">E.g. kapman does this:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">ecm_install_icons(ICONS 128-apps-kapman.png 16-apps-kapman.png 22-apps-kapman.png 32-apps-kapman.png 48-apps-kapman.png 64-apps-kapman.png DESTINATION <span style="color: #BC7A00">${</span>KDE_INSTALL_ICONDIR<span style="color: #BC7A00">}</span> THEME hicolor)
file(GLOB ICONS_SRCS "<span style="color: #BC7A00">${</span>CMAKE_CURRENT_SOURCE_DIR<span style="color: #BC7A00">}</span>/*-apps-kapman.png")
ecm_add_app_icon(kapman_SRCS ICONS <span style="color: #BC7A00">${</span>ICONS_SRCS<span style="color: #BC7A00">}</span>)
</pre></div>
</p></pre>
</blockquote>
<p>On april 11th, 2015, 9:36 a.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ah, ok there is ecm_install_icons() in ./pictures/CMakeLists.txt...</p></pre>
</blockquote>
<p>On april 11th, 2015, 9:42 a.m. UTC, <b>Minh Ngo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, so let's wait for Ian's review then, because I don't have a Mac to check (previously you have removed him from reviewers list).</p></pre>
</blockquote>
<p>On april 11th, 2015, 10:53 a.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you test building with this patch on Linux, Minh?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding to your last changes. In Linux it generates plugins with a prefix libkdots_* ( http://build.kde.org/job/kdots_master_qt5/8/console ) and in my code I'm trying to look for this prefix. It can be a reason why plugins cannot be found in Mac.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you try to change it for Mac here? http://quickgit.kde.org/?p=kdots.git&a=blob&h=d983ae240aad354e8db33e34c72fa3d41f8ef029&hb=e7fdd108b8c078ad864df7581a28d75adfb82327&f=kdotslib%2Fconstants.hpp</p></pre>
<br />
<p>- Minh</p>
<br />
<p>On april 11th, 2015, 10:51 a.m. UTC, Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games, Ian Wadham and Minh Ngo.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated apr 11, 2015, 10:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdots
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Minh,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've added a RB config as well as introduced some changes re std:abs() specific to OSX. Also I added a forgotten include.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There's another issue to be fixed, but I'll post this to the mailing list independently.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Greets,
Marko</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds now also on OSX.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(81b1273bee0f5c930ec350edfd2030150b053ee1)</span></li>
<li>kdotslib/polygon.hpp <span style="color: grey">(dca4b55594372be7db96e92f11dc8af39052ce1e)</span></li>
<li>kdotslib/polygon.cpp <span style="color: grey">(ace662d08b4984dc87744acebebe7f7c26172a97)</span></li>
<li>kdotslib/stepqueue.hpp <span style="color: grey">(2ff853e558e69ba31122245b1bdb5cd240e45afb)</span></li>
<li>pictures/CMakeLists.txt <span style="color: grey">(90cebc068fe4a85b8370368fbebc8ec597412af7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123328/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>