[Kde-games-devel] Review Request 120297: Patch to avoid build failure of bovo

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120297/
-----------------------------------------------------------

(Updated Sept. 21, 2014, 4:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games, Ian Wadham and Raymond Wooninck.


Repository: bovo


Description
-------

Errors like this break bovo's build on OSX and Linux
```
     /Users/marko/WC/KDECI-builds/bovo/ai/aron/aiboard.cc:450:11: error: non-constant-expression cannot
       be narrowed from type 'int' to 'usi' (aka        'unsigned short') in initializer list [-Wc++11-narrowing]
        LEFT | UP,
        ^~~~~~~~~
```
due to non-constant expressions being generated by the compiler.

---

Still, this patch alone doesn't look nice. I think re-defining those constants FOUR times should be avoided. 


Diffs
-----

  ai/aron/aiboard.cc 91d8192 
  game/game.cc c000a89 

Diff: https://git.reviewboard.kde.org/r/120297/diff/


Testing
-------

Builds fine with this patch applied.


Thanks,

Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140921/25d6f1cc/attachment.html>