[Kde-games-devel] Review Request 120297: Patch to avoid build failure of bovo

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120297/#review67108
-----------------------------------------------------------

Ship it!


agreed, it's not really cool to redefine those, but it's at least a step forward.

- Albert Astals Cid


On set. 20, 2014, 1:38 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120297/
> -----------------------------------------------------------
> 
> (Updated set. 20, 2014, 1:38 p.m.)
> 
> 
> Review request for KDE Games, Ian Wadham and Raymond Wooninck.
> 
> 
> Repository: bovo
> 
> 
> Description
> -------
> 
> Errors like this break bovo's build on OSX and Linux
> ```
>      /Users/marko/WC/KDECI-builds/bovo/ai/aron/aiboard.cc:450:11: error: non-constant-expression cannot
>        be narrowed from type 'int' to 'usi' (aka        'unsigned short') in initializer list [-Wc++11-narrowing]
>         LEFT | UP,
>         ^~~~~~~~~
> ```
> due to non-constant expressions being generated by the compiler.
> 
> ---
> 
> Still, this patch alone doesn't look nice. I think re-defining those constants FOUR times should be avoided. 
> 
> 
> Diffs
> -----
> 
>   ai/aron/aiboard.cc 91d8192 
>   game/game.cc c000a89 
> 
> Diff: https://git.reviewboard.kde.org/r/120297/diff/
> 
> 
> Testing
> -------
> 
> Builds fine with this patch applied.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140921/253f78bd/attachment.html>