[Kde-games-devel] Review Request 120288: Initial port to Frameworks

[Raymond Wooninck]

> On Sept. 19, 2014, 7:31 p.m., Hrvoje Senjan wrote:
> > CMakeLists.txt, line 9
> > <https://git.reviewboard.kde.org/r/120288/diff/1/?file=313480#file313480line9>
> >
> >     maybe to use 1.0.0 - that is the first 'real' release?

Updated


> On Sept. 19, 2014, 7:31 p.m., Hrvoje Senjan wrote:
> > CMakeLists.txt, line 13
> > <https://git.reviewboard.kde.org/r/120288/diff/1/?file=313480#file313480line13>
> >
> >     even though Gui module is pulled in indirectly, i would search it explicitly here

Added


> On Sept. 19, 2014, 7:31 p.m., Hrvoje Senjan wrote:
> > CMakeLists.txt, line 49
> > <https://git.reviewboard.kde.org/r/120288/diff/1/?file=313480#file313480line49>
> >
> >     depending which CMake version, those all could end up being public, and from quick climpse, looks like only QtGui and KConfigWidgets should be

Ok. Changed it to reflect public and private libs


> On Sept. 19, 2014, 7:31 p.m., Hrvoje Senjan wrote:
> > CMakeLists.txt, line 59
> > <https://git.reviewboard.kde.org/r/120288/diff/1/?file=313480#file313480line59>
> >
> >     imo, it would be a good idea to also install the config files, i see both kmahjongg and kshisen have copies of FindLibKMahjongg.cmake, that would make it obsolete...

I knew that I forgot something :)  Update includes the standard Config.cmake files.


- Raymond


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120288/#review66981
-----------------------------------------------------------


On Sept. 19, 2014, 8:18 p.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120288/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 8:18 p.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid and Hrvoje Senjan.
> 
> 
> Repository: libkmahjongg
> 
> 
> Description
> -------
> 
> Initial port to Frameworks. This would mean that a new branch Frameworks is created for this library where we can work further on it
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8db109d 
>   KF5KMahjongglibConfig.cmake.in PRE-CREATION 
>   KF5KMahjongglibConfigVersion.cmake.in PRE-CREATION 
>   kmahjonggbackground.cpp c63968f 
>   kmahjonggbackgroundselector.cpp 1ed407f 
>   kmahjonggconfigdialog.h ed27f41 
>   kmahjonggconfigdialog.cpp c90fefd 
>   kmahjonggtileset.cpp 938e292 
>   kmahjonggtilesetselector.cpp 6e32867 
> 
> Diff: https://git.reviewboard.kde.org/r/120288/diff/
> 
> 
> Testing
> -------
> 
> Library compiles without deprecated warnings and errors. Functionality can only be tested once kmahjongg itself is ported (which would be the next step)
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140919/0bc788fa/attachment.html>