[Kde-games-devel] Review Request 120288: Initial port to Frameworks

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120288/#review66981
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/120288/#comment46718>

    maybe to use 1.0.0 - that is the first 'real' release?



CMakeLists.txt
<https://git.reviewboard.kde.org/r/120288/#comment46720>

    even though Gui module is pulled in indirectly, i would search it explicitly here



CMakeLists.txt
<https://git.reviewboard.kde.org/r/120288/#comment46726>

    depending which CMake version, those all could end up being public, and from quick climpse, looks like only QtGui and KConfigWidgets should be



CMakeLists.txt
<https://git.reviewboard.kde.org/r/120288/#comment46722>

    imo, it would be a good idea to also install the config files, i see both kmahjongg and kshisen have copies of FindLibKMahjongg.cmake, that would make it obsolete...


- Hrvoje Senjan


On Sept. 19, 2014, 8:54 p.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120288/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 8:54 p.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid and Hrvoje Senjan.
> 
> 
> Repository: libkmahjongg
> 
> 
> Description
> -------
> 
> Initial port to Frameworks. This would mean that a new branch Frameworks is created for this library where we can work further on it
> 
> 
> Diffs
> -----
> 
>   kmahjonggtilesetselector.cpp 6e32867 
>   CMakeLists.txt 8db109d 
>   kmahjonggbackground.cpp c63968f 
>   kmahjonggbackgroundselector.cpp 1ed407f 
>   kmahjonggconfigdialog.h ed27f41 
>   kmahjonggconfigdialog.cpp c90fefd 
>   kmahjonggtileset.cpp 938e292 
> 
> Diff: https://git.reviewboard.kde.org/r/120288/diff/
> 
> 
> Testing
> -------
> 
> Library compiles without deprecated warnings and errors. Functionality can only be tested once kmahjongg itself is ported (which would be the next step)
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140919/1e420782/attachment.html>