[Kde-games-devel] Review Request 119585: Make unpause on restore work for maximized window

[Jan-Peter Nilsson]

> On Oct. 14, 2014, 12:12 a.m., Albert Astals Cid wrote:
> > Are you sure this is only a partial fix? It seems to me that this actually fixes both scenarios mentioned in the bug, no? Which is missing to be fixed?

The second part of B, minimizing an already paused game will unpause it for the duration it is minimized.
changeEvent should check if the game is already paused and not toggle pause if it already is paused when minimizing.
I have a patch for that as well but review board will not let me upload it as it depends on this one.

After fixing so that minimize don't unpause we probably also want to make restore not unpause a manually paused game as well, but that is not really part of the original bug description.


- Jan-Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119585/#review68334
-----------------------------------------------------------


On Oct. 13, 2014, 10:18 p.m., Jan-Peter Nilsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119585/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 10:18 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 332656
>     http://bugs.kde.org/show_bug.cgi?id=332656
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> For a maximied window the oldState will also contain Qt::WindowMaximized
> so we need to filter out just the bit flag we are interested in.
> 
> As there is several problems described in bug 332656 this is just a partial correction.
> 
> 
> Diffs
> -----
> 
>   kmahjongg.cpp e4f5c49 
> 
> Diff: https://git.reviewboard.kde.org/r/119585/diff/
> 
> 
> Testing
> -------
> 
> Minimized and restored a maximized KMahjongg window.
> 
> 
> Thanks,
> 
> Jan-Peter Nilsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141014/5b5d0b27/attachment.html>