[Kde-games-devel] Review Request 119585: Make unpause on restore work for maximized window

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119585/#review68334
-----------------------------------------------------------


Are you sure this is only a partial fix? It seems to me that this actually fixes both scenarios mentioned in the bug, no? Which is missing to be fixed?

- Albert Astals Cid


On oct. 13, 2014, 8:18 p.m., Jan-Peter Nilsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119585/
> -----------------------------------------------------------
> 
> (Updated oct. 13, 2014, 8:18 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 332656
>     http://bugs.kde.org/show_bug.cgi?id=332656
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> For a maximied window the oldState will also contain Qt::WindowMaximized
> so we need to filter out just the bit flag we are interested in.
> 
> As there is several problems described in bug 332656 this is just a partial correction.
> 
> 
> Diffs
> -----
> 
>   kmahjongg.cpp e4f5c49 
> 
> Diff: https://git.reviewboard.kde.org/r/119585/diff/
> 
> 
> Testing
> -------
> 
> Minimized and restored a maximized KMahjongg window.
> 
> 
> Thanks,
> 
> Jan-Peter Nilsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20141013/7f119be8/attachment.html>