[Kde-games-devel] Review Request 119439: fix for bug #335007: konquest misses available artwork for rendering planets

Martin Walch walch.martin at web.de
Wed Jul 23 21:49:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119439/
-----------------------------------------------------------

Review request for KDE Games.


Bugs: 335007
    http://bugs.kde.org/show_bug.cgi?id=335007


Repository: konquest


Description
-------

Back in May I opened bug #335007 and posted this patch there.

It activates the use of the currently unused artwork "planet_10" (green planet).

The look of the individual planets is randomly assigned with numbers from 0 to 8 with KRandomSequence::getLong(9), later mapping to 1 to 9. But there are 10 different pictures for planets. Therefore change getLong(9) to getLong(10).


Diffs
-----

  planet.cc e6f20d6 

Diff: https://git.reviewboard.kde.org/r/119439/diff/


Testing
-------

Applied patch successfully to master, KDE/4.13 and KDE/4.14.
Builds fine. When running the game, the green planet is randomly in use.


Thanks,

Martin Walch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140723/602fd5f2/attachment.html>


More information about the kde-games-devel mailing list