[Kde-games-devel] Review Request 115365: New design for KReversi

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115365/#review48494
-----------------------------------------------------------

Ship it!


I could only find trivial problems so for me you can merge the branch after fixing those.


kreversigame.h
<https://git.reviewboard.kde.org/r/115365/#comment34287>

    Even if this was true, which I don't think it is, I don't think this type of comment belongs in the source code.



kreversiview.cpp
<https://git.reviewboard.kde.org/r/115365/#comment34288>

    I would write "White can not perform..." instead of "White player...".  Same with Black a few lines down.



mainwindow.cpp
<https://git.reviewboard.kde.org/r/115365/#comment34289>

    If this function is not needed anymore I think it should be removed.



mainwindow.cpp
<https://git.reviewboard.kde.org/r/115365/#comment34290>

    Should perhaps be "black wins" instead.  Or is "you" appropriate here?


- Inge Wallin


On Jan. 28, 2014, 7:28 p.m., Denis Kuplyakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115365/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 7:28 p.m.)
> 
> 
> Review request for KDE Games and Inge Wallin.
> 
> 
> Repository: kreversi
> 
> 
> Description
> -------
> 
> New design for KReversi with many new features and huge amount of rewrited code.
> 
> Purpose of the changes described here: http://kreversiqml.blogspot.ru/2013/08/new-kreversi-design.html
> Complete scheme of new code: https://projects.kde.org/projects/kde/kdegames/kreversi/repository/entry/DESIGN_SCHEME.png?rev=deniskup%2Fnewdesign%2Fnopatch
> 
> Major features:
> 1) code rewrite
> 2) brand-new Start Game dialog
> 3) ability to play whites, also you can now play with a friend
> 4) demo mode is now a computer-computer match, and computers can have different difficulties
> 5...) maybe I've forgotten something
> 
> 
> Diffs
> -----
> 
>   DESIGN b1ae729 
>   DESIGN_SCHEME.png PRE-CREATION 
>   Engine.h 6f8340d 
>   Engine.cpp 846b519 
>   TODO d4c6bc9 
>   colorscheme.h 2e5a0e7 
>   colorscheme.cpp e10228c 
>   commondefs.h 57b0f6a 
>   commondefs.cpp PRE-CREATION 
>   gamestartinformation.h PRE-CREATION 
>   highscores.h aa04604 
>   highscores.cpp 7c7cb56 
>   kreversicomputerplayer.h PRE-CREATION 
>   kreversicomputerplayer.cpp PRE-CREATION 
>   kreversigame.h c54ef05 
>   kreversigame.cpp f77c396 
>   kreversihumanplayer.h PRE-CREATION 
>   kreversihumanplayer.cpp PRE-CREATION 
>   kreversiplayer.h PRE-CREATION 
>   kreversiplayer.cpp PRE-CREATION 
>   kreversiview.h 5529f8d 
>   kreversiview.cpp 21bbe30 
>   main.cpp ee8b9c7 
>   mainwindow.h 3ffb2dc 
>   mainwindow.cpp 0a0f5a0 
>   qml/Board.qml 6657fe1 
>   qml/CanvasItem.qml 9364e21 
>   qml/Cell.qml e20f336 
>   qml/Chip.qml a0c9d0c 
>   qml/Popup.qml 378b57c 
>   qml/Table.qml b989d57 
>   qml/globals.js 7deec4f 
>   startgamedialog.h PRE-CREATION 
>   startgamedialog.cpp PRE-CREATION 
>   startgamedialog.ui PRE-CREATION 
>   AUTHORS 65bb7f6 
>   CMakeLists.txt d0ddeea 
> 
> Diff: https://git.reviewboard.kde.org/r/115365/diff/
> 
> 
> Testing
> -------
> 
> Have played it a lot, all is OK!
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140128/2391411b/attachment.html>