<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115365/">https://git.reviewboard.kde.org/r/115365/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I could only find trivial problems so for me you can merge the branch after fixing those.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115365/diff/1/?file=240889#file240889line269" style="color: black; font-weight: bold; text-decoration: underline;">kreversigame.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">232</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// Well I'm not brief at all :). That's because I think that my</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">233</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// English is not well shaped sometimes, so I try to describe things</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">234</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// so that me and others can understand. Even simple things.</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">235</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// Specially when I think that my description sucks :)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Even if this was true, which I don't think it is, I don't think this type of comment belongs in the source code.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115365/diff/1/?file=240896#file240896line297" style="color: black; font-weight: bold; text-decoration: underline;">kreversiview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KReversiView::setShowLegalMoves(bool show)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">282</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">i18n</span><span class="p">(</span><span class="s">"<span class="hl">Comput</span>er can not move. It is <span class="hl">your</span> turn again."</span><span class="p">)));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">246</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">i18n</span><span class="p">(</span><span class="s">"<span class="hl">White play</span>er can not<span class="hl"> perform any</span> move. It is <span class="hl">black</span> turn again."</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would write "White can not perform..." instead of "White player...". Same with Black a few lines down.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115365/diff/1/?file=240899#file240899line273" style="color: black; font-weight: bold; text-decoration: underline;">mainwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KReversiMainWindow::slotToggleDemoMode()</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">211</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">KReversiMainWindow</span><span class="o">::</span><span class="n">slotToggleDemoMode</span><span class="p">()</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">202</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span class="hl">//</span>void KReversiMainWindow::slotToggleDemoMode()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this function is not needed anymore I think it should be removed.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115365/diff/1/?file=240899#file240899line368" style="color: black; font-weight: bold; text-decoration: underline;">mainwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KReversiMainWindow::slotToggleDemoMode()</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">258</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">res</span> <span class="o">=</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"You win!"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should perhaps be "black wins" instead. Or is "you" appropriate here?</pre>
</div>
<br />
<p>- Inge Wallin</p>
<br />
<p>On January 28th, 2014, 7:28 p.m. UTC, Denis Kuplyakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Inge Wallin.</div>
<div>By Denis Kuplyakov.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2014, 7:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kreversi
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New design for KReversi with many new features and huge amount of rewrited code.
Purpose of the changes described here: http://kreversiqml.blogspot.ru/2013/08/new-kreversi-design.html
Complete scheme of new code: https://projects.kde.org/projects/kde/kdegames/kreversi/repository/entry/DESIGN_SCHEME.png?rev=deniskup%2Fnewdesign%2Fnopatch
Major features:
1) code rewrite
2) brand-new Start Game dialog
3) ability to play whites, also you can now play with a friend
4) demo mode is now a computer-computer match, and computers can have different difficulties
5...) maybe I've forgotten something</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have played it a lot, all is OK!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>DESIGN <span style="color: grey">(b1ae729)</span></li>
<li>DESIGN_SCHEME.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>Engine.h <span style="color: grey">(6f8340d)</span></li>
<li>Engine.cpp <span style="color: grey">(846b519)</span></li>
<li>TODO <span style="color: grey">(d4c6bc9)</span></li>
<li>colorscheme.h <span style="color: grey">(2e5a0e7)</span></li>
<li>colorscheme.cpp <span style="color: grey">(e10228c)</span></li>
<li>commondefs.h <span style="color: grey">(57b0f6a)</span></li>
<li>commondefs.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>gamestartinformation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>highscores.h <span style="color: grey">(aa04604)</span></li>
<li>highscores.cpp <span style="color: grey">(7c7cb56)</span></li>
<li>kreversicomputerplayer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kreversicomputerplayer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kreversigame.h <span style="color: grey">(c54ef05)</span></li>
<li>kreversigame.cpp <span style="color: grey">(f77c396)</span></li>
<li>kreversihumanplayer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kreversihumanplayer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kreversiplayer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kreversiplayer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kreversiview.h <span style="color: grey">(5529f8d)</span></li>
<li>kreversiview.cpp <span style="color: grey">(21bbe30)</span></li>
<li>main.cpp <span style="color: grey">(ee8b9c7)</span></li>
<li>mainwindow.h <span style="color: grey">(3ffb2dc)</span></li>
<li>mainwindow.cpp <span style="color: grey">(0a0f5a0)</span></li>
<li>qml/Board.qml <span style="color: grey">(6657fe1)</span></li>
<li>qml/CanvasItem.qml <span style="color: grey">(9364e21)</span></li>
<li>qml/Cell.qml <span style="color: grey">(e20f336)</span></li>
<li>qml/Chip.qml <span style="color: grey">(a0c9d0c)</span></li>
<li>qml/Popup.qml <span style="color: grey">(378b57c)</span></li>
<li>qml/Table.qml <span style="color: grey">(b989d57)</span></li>
<li>qml/globals.js <span style="color: grey">(7deec4f)</span></li>
<li>startgamedialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>startgamedialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>startgamedialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>AUTHORS <span style="color: grey">(65bb7f6)</span></li>
<li>CMakeLists.txt <span style="color: grey">(d0ddeea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115365/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>