[Kde-games-devel] Review Request 114974: Add example player to konquest when built in non-release mode

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114974/#review48299
-----------------------------------------------------------

Ship it!


Looks good to me.

- Albert Astals Cid


On Jan. 26, 2014, 4:22 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114974/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2014, 4:22 p.m.)
> 
> 
> Review request for KDE Games and Alexander Schuch.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> Just realized that we didn't include example player in (all) debug build types.
> http://techbase.kde.org/Development/Tutorials/Debugging/Debugging_symbols#And_make.3F
> 
> Alternative is to set it just for some build types, like:
> - for debug:  set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -DKONQUEST_DEBUG")
> - for debugfull set(CMAKE_CXX_FLAGS_DEBUG_FULL "${CMAKE_CXX_FLAGS_DEBUG_FULL} -DKONQUEST_DEBUGFULL")
> but I'm not sure that we want to do that.
> 
> 
> Diffs
> -----
> 
>   dialogs/newgamedlg.cc 0485cdd 
>   CMakeLists.txt a20ce0b 
> 
> Diff: https://git.reviewboard.kde.org/r/114974/diff/
> 
> 
> Testing
> -------
> 
> Checked with release, debug and debugfull build types. Example player is not shown in release.
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140126/c30dabec/attachment.html>