[Kde-games-devel] Review Request 114974: Add example player to konquest when built in non-release mode

[Nemanja Hirsl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114974/
-----------------------------------------------------------

(Updated Jan. 26, 2014, 4:22 p.m.)


Review request for KDE Games and Alexander Schuch.


Changes
-------

At first, I thought to introduce new compile switch; but then having exaple player in all build types except release seemed like nice solution. Now, if this is the case Albert, I have reverted code to the first idea:
New option is KONQUEST_EXAMPLE_PLAYER. If it is not set, it will default to OFF and example player won't be added. If it is set, e.g. -DKONQUEST_EXAMPLE_PLAYER=on two source files will be added to the list of all program files and KONQUEST_EXAMPLE_PLAYER define propagated to code as #define. The later can be also achieved by setting #cmakedefine KONQUEST_EXAMPLE_PLAYER in .h.in file.


Repository: konquest


Description
-------

Just realized that we didn't include example player in (all) debug build types.
http://techbase.kde.org/Development/Tutorials/Debugging/Debugging_symbols#And_make.3F

Alternative is to set it just for some build types, like:
- for debug:  set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -DKONQUEST_DEBUG")
- for debugfull set(CMAKE_CXX_FLAGS_DEBUG_FULL "${CMAKE_CXX_FLAGS_DEBUG_FULL} -DKONQUEST_DEBUGFULL")
but I'm not sure that we want to do that.


Diffs (updated)
-----

  dialogs/newgamedlg.cc 0485cdd 
  CMakeLists.txt a20ce0b 

Diff: https://git.reviewboard.kde.org/r/114974/diff/


Testing
-------

Checked with release, debug and debugfull build types. Example player is not shown in release.


Thanks,

Nemanja Hirsl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140126/de68a3c3/attachment.html>