[Kde-games-devel] Review Request 114851: Center board vertically if required.

[Alexander Schuch]

> On Jan. 4, 2014, 12:32 p.m., Alexander Schuch wrote:
> > map/mapscene.cc, line 144
> > <https://git.reviewboard.kde.org/r/114851/diff/1/?file=229963#file229963line144>
> >
> >     kdelibs requires Qt 4.8 or later? If that's true, this hack can be removed, right? At least I am unable to see a difference with or without that line.
> 
> Albert Astals Cid wrote:
>     set (QT_MIN_VERSION "4.8.0")
>     in kdelibs

As I do not see any difference, I simply dropped that work-around.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114851/#review46762
-----------------------------------------------------------


On Jan. 5, 2014, 3:36 p.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114851/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 3:36 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The board is centered horizontally already in case the board is tall. If
> it is wide however, it still is aligned to the top leaving empty space
> just at the bottom. This patch vertically centers a wide board.
> 
> 
> Diffs
> -----
> 
>   map/mapitems.cc 2216dda 
>   map/mapscene.h 79666be 
>   map/mapscene.cc ba53c23 
> 
> Diff: https://git.reviewboard.kde.org/r/114851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140105/11f7a908/attachment.html>