[Kde-games-devel] Review Request 114851: Center board vertically if required.
Albert Astals Cid
aacid at kde.org
Sat Jan 4 18:49:28 UTC 2014
> On Jan. 4, 2014, 12:32 p.m., Alexander Schuch wrote:
> > map/mapscene.cc, line 144
> > <https://git.reviewboard.kde.org/r/114851/diff/1/?file=229963#file229963line144>
> >
> > kdelibs requires Qt 4.8 or later? If that's true, this hack can be removed, right? At least I am unable to see a difference with or without that line.
set (QT_MIN_VERSION "4.8.0")
in kdelibs
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114851/#review46762
-----------------------------------------------------------
On Jan. 4, 2014, 12:30 p.m., Alexander Schuch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114851/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2014, 12:30 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: konquest
>
>
> Description
> -------
>
> The board is centered horizontally already in case the board is tall. If
> it is wide however, it still is aligned to the top leaving empty space
> just at the bottom. This patch vertically centers a wide board.
>
>
> Diffs
> -----
>
> map/mapitems.cc 2216dda
> map/mapscene.h 79666be
> map/mapscene.cc ba53c23
>
> Diff: https://git.reviewboard.kde.org/r/114851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Schuch
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140104/714f8e4b/attachment.html>
More information about the kde-games-devel
mailing list