[Kde-games-devel] Review Request 114840: Play a fade-in animation to show the adversary's ships after a defeat.

Roney Gomes roney477 at gmail.com
Fri Jan 3 20:30:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114840/
-----------------------------------------------------------

(Updated Jan. 3, 2014, 8:30 p.m.)


Review request for KDE Games and Jaime Torres Amate.


Repository: knavalbattle


Description
-------

Enemy ships now appear in both single player and network mode, that's cool. However, when I first started to work on this feature the ships appeared smoothly on the table after the player pressed the "OK" button of the ending KMessageBox.

As Jaime didn't work directly on the branch I set up he may have missed these two lines of code.


Diffs
-----

  src/battlefieldview.cpp b682757 
  src/controller.cpp df44ff4 

Diff: https://git.reviewboard.kde.org/r/114840/diff/


Testing
-------

I've lost the game a few times in order to see the enemy ships appearing.


Thanks,

Roney Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140103/06138480/attachment.html>


More information about the kde-games-devel mailing list