[Kde-games-devel] Review Request 116483: Restart button works and uses the current game configuration

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116483/
-----------------------------------------------------------

Review request for KDE Games and Roney Gomes.


Repository: knavalbattle


Description
-------

The restart button made the network game use the wrong configuration (it created a new controller), now it uses the current game configuration (and controller). It restarted the chat and sent again the nick, now it is not needed and is not done.

I have introduced, I needed it desperately, the name of the message interchanged as an XML attribute (totally backwards compatible). in protocol.cpp and message.h


Diffs
-----

  src/controller.h eb5f63f 
  src/controller.cpp 3a26170 
  src/entity.h c6fcdbc 
  src/entity.cpp 3104029 
  src/mainwindow.cpp 7ef4482 
  src/message.h 58b5beb 
  src/networkentity.h aa66543 
  src/networkentity.cpp f19b1d5 
  src/playerentity.cpp c6b0a1d 
  src/playfield.h 5766022 
  src/playfield.cpp 5ebfbc2 
  src/protocol.cpp 2416164 
  src/sea.cpp 77a8864 

Diff: https://git.reviewboard.kde.org/r/116483/diff/


Testing
-------

Lots of network games against myself (and some local games against AI too).
Place half the ships to see if it was possible to start to shoot too soon, make one of them unable to finish placing the remaining ships several times, then finish it... waiting for the opposite to finish placing ships. Do the same with the other player.. Start shooting (some times finishing the game), and then press restart. 


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140228/6b49f685/attachment.html>