[Kde-games-devel] Review Request 119774: code cleanup

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119774/#review64501
-----------------------------------------------------------

Ship it!


Thanks, i'll commit it in a minute.

- Albert Astals Cid


On ago. 13, 2014, 7:52 p.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119774/
> -----------------------------------------------------------
> 
> (Updated ago. 13, 2014, 7:52 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: lskat
> 
> 
> Description
> -------
> 
> * remove unused variable "int result" from Mainwindow::menuCardDeck()
> * merge redundant code path for "action->setEnabled(false)" from Mainwindow::initGUI()
> * use initializer list for ThemeManager constructor
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp 5f7c693 
>   src/thememanager.cpp 1746378 
> 
> Diff: https://git.reviewboard.kde.org/r/119774/diff/
> 
> 
> Testing
> -------
> 
> Successfully applied and built on KDE/4.14 and master.
> 
> No problems detected when building and running KDE/4.14 branch with 4.13 libs.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140813/16f6ce5b/attachment.html>