[Kde-games-devel] Review Request 119774: code cleanup

Martin Walch walch.martin at web.de
Wed Aug 13 19:52:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119774/
-----------------------------------------------------------

Review request for KDE Games.


Summary (updated)
-----------------

code cleanup


Repository: lskat


Description (updated)
-------

* remove unused variable "int result" from Mainwindow::menuCardDeck()
* merge redundant code path for "action->setEnabled(false)" from Mainwindow::initGUI()
* use initializer list for ThemeManager constructor


Diffs (updated)
-----

  src/mainwindow.cpp 5f7c693 
  src/thememanager.cpp 1746378 

Diff: https://git.reviewboard.kde.org/r/119774/diff/


Testing (updated)
-------

Successfully applied and built on KDE/4.14 and master.

No problems detected when building and running KDE/4.14 branch with 4.13 libs.


Thanks,

Martin Walch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140813/2bd68b5c/attachment-0001.html>


More information about the kde-games-devel mailing list