[Kde-games-devel] Review Request 109885: Real life projectile motion of bombs included

[Albert Astals Cid]

> On April 6, 2013, 10 p.m., Albert Astals Cid wrote:
> > Besides broken spacing, i think it'd make sense having an option to toggle between the modes, people may like the current behaviour mroe even if it's irreal
> 
> Ashwin Rajeev wrote:
>     i dont think that is a good idea. IMO either select this or stick to the old one.
> 
> Albert Astals Cid wrote:
>     Why are you against something that offers more versatility and offers different ways of playing?
> 
> Anant  Pushkar wrote:
>     If we allow user to toggle between two modes, we must have two scoring algorithms as scoring in projectile mode is a little more difficult.
> 
> Albert Astals Cid wrote:
>     Agreed.
> 
> Albert Astals Cid wrote:
>     Ping?

5 months after the last comment from the submitter I'm going to discard the review to help maintaining clean and meaningful tables in reviewboard. If you ever get to address the comments we made in this review, please open a new one.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109885/#review30585
-----------------------------------------------------------


On April 6, 2013, 3:06 p.m., Anant  Pushkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109885/
> -----------------------------------------------------------
> 
> (Updated April 6, 2013, 3:06 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> The bombs earlier used to fall in straight line vertically. In this patch, I have made the path of the bomb a projectile just like in real life to make it look realistic. A side effect of this is that hitting the buildings in the beginning would be a little difficult. To tackle this, the average height of the first two buildings have been reduced.
> 
> Also, in cases when the plane crashes and not many blocks are still left, taking an aim from a larger height becomes difficult. Due to this the player has to wait till the plane itself comes down to a desired height. So, I have added a function that allows the player to lower the altitude of the plane by pressing the down button. I have a number of other features in mind that can be implemented as well. I will be soon submitting them.
> 
> 
> Diffs
> -----
> 
>   src/board.h 3816b95 
>   src/board.cpp 1dd99a3 
>   src/bomb.h adf8541 
>   src/bomb.cpp 7d361f5 
>   src/bomber.cpp 4cd276f 
>   src/bomberwidget.h d807294 
>   src/bomberwidget.cpp 497d8e1 
>   src/explodable.h aca7735 
>   src/explodable.cpp 773f55f 
>   src/main.cpp 05f4686 
>   src/plane.h acc8c8b 
>   src/plane.cpp a805415 
> 
> Diff: http://git.reviewboard.kde.org/r/109885/diff/
> 
> 
> Testing
> -------
> 
> I would also like to add that I have tested the changes exhaustively and have found it to work well and improve the user experience.
> 
> 
> Thanks,
> 
> Anant  Pushkar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130925/9b2cb416/attachment.html>