[Kde-games-devel] Review Request 110126: Changed two QTimer objects to QTimeLine objects, so that pause and resume functionality can be used to pause the Timers when the game is paused.

[Albert Astals Cid]

> On June 16, 2013, 2:17 p.m., Albert Astals Cid wrote:
> > Dishant how is this going?

Dishant, are you going to work on this? Or shall I just discard it and you create a new request in the future if you end up adressing the comments?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110126/#review34421
-----------------------------------------------------------


On April 25, 2013, 9:13 p.m., Dishant  Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110126/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 9:13 p.m.)
> 
> 
> Review request for KDE Games and Viranch Mehta.
> 
> 
> Description
> -------
> 
> With respect to the bug, https://bugs.kde.org/show_bug.cgi?id=190372, i have implemented the m_bonusTimer and m_preyTimer timers to pause when the game state is Paused, and the timers resume when the game state resumes.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=190372.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=190372
> 
> 
> Diffs
> -----
> 
>   game.h be82b55 
>   game.cpp ddbc106 
> 
> Diff: http://git.reviewboard.kde.org/r/110126/diff/
> 
> 
> Testing
> -------
> 
> Yes,it works fine in my system.
> 
> 
> Thanks,
> 
> Dishant  Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130925/cf954975/attachment.html>