[Kde-games-devel] Review Request 112676: refactor player selection

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112676/
-----------------------------------------------------------

Review request for KDE Games.


Summary (updated)
-----------------

refactor player selection


Description (updated)
-------

The default AI is handled by players/ai/default/default.cpp. The difficulty is wrapped in own classes so that the external interface is the same for all players (AI and human).

Adding new AI players is as easy as to implement the code in an own class, add a GUI wrapper (see ai/example) and add the GUI wrapper to m_selectablePlayer in NewGameDlg constructor.


Diffs
-----

  CMakeLists.txt 0e8a354 
  dialogs/newgamedlg.h 10ce4ee 
  dialogs/newgamedlg.cc be764f1 
  players/ai/default/default.h PRE-CREATION 
  players/ai/default/default.cpp PRE-CREATION 
  players/ai/default/hard.h PRE-CREATION 
  players/ai/default/hard.cpp PRE-CREATION 
  players/ai/default/hard_gui.h PRE-CREATION 
  players/ai/default/hard_gui.cpp PRE-CREATION 
  players/ai/default/normal.h PRE-CREATION 
  players/ai/default/normal.cpp PRE-CREATION 
  players/ai/default/normal_gui.h PRE-CREATION 
  players/ai/default/normal_gui.cpp PRE-CREATION 
  players/ai/default/weak.h PRE-CREATION 
  players/ai/default/weak.cpp PRE-CREATION 
  players/ai/default/weak_gui.h PRE-CREATION 
  players/ai/default/weak_gui.cpp PRE-CREATION 
  players/ai/example/example.h PRE-CREATION 
  players/ai/example/example.cpp PRE-CREATION 
  players/ai/example/example_gui.h PRE-CREATION 
  players/ai/example/example_gui.cpp PRE-CREATION 
  players/computerplayer.h ec25217 
  players/computerplayer.cpp 2df7dd8 
  players/localplayer_gui.h PRE-CREATION 
  players/localplayer_gui.cpp PRE-CREATION 
  players/player.h be0133a 
  players/player_gui.h PRE-CREATION 
  players/player_gui.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112676/diff/


Testing
-------


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130915/61aa5c3c/attachment.html>