[Kde-games-devel] Review Request 113512: Animation fix for KReversi
Albert Astals Cid
aacid at kde.org
Wed Oct 30 22:58:14 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113512/#review42724
-----------------------------------------------------------
There's a too big initial delay, see the old code, it started much faster to turn the first chip.
- Albert Astals Cid
On Oct. 30, 2013, 7:29 p.m., Denis Kuplyakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113512/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 7:29 p.m.)
>
>
> Review request for KDE Games, Albert Astals Cid and Viranch Mehta.
>
>
> Repository: kreversi
>
>
> Description
> -------
>
> This fixes animation for KReversi. Now chips are turning "as wave" from player's move position.
>
>
> Diffs
> -----
>
> kreversiview.h 2356fe7
> kreversiview.cpp b7a9ddf
> qml/Board.qml 60c6814
> qml/Cell.qml 2007265
> qml/Chip.qml 78d65bb
> qml/Table.qml 158ba65
>
> Diff: http://git.reviewboard.kde.org/r/113512/diff/
>
>
> Testing
> -------
>
> I have tested it a bit, seems to work.
>
>
> Thanks,
>
> Denis Kuplyakov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131030/156a5f8a/attachment.html>
More information about the kde-games-devel
mailing list