[Kde-games-devel] Review Request 111662: Hard AI for KSquares

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111662/#review41797
-----------------------------------------------------------



src/aicontroller.cpp
<http://git.reviewboard.kde.org/r/111662/#comment30521>

    This was removed because it was a no-op, right?



src/aicontroller.cpp
<http://git.reviewboard.kde.org/r/111662/#comment30522>

    If you use a QScopedPointer here you won't need all the deletes in each and every return path, making it easier not to forget about one.



src/aicontroller.cpp
<http://git.reviewboard.kde.org/r/111662/#comment30523>

    This if is "new" for the "old" difficulties, isn't it? Is that something we want? or is the old one enough?



src/ksquareswindow.cpp
<http://git.reviewboard.kde.org/r/111662/#comment30520>

    Shouldn't this be Hard,Hard and not Medium,Hard?


- Albert Astals Cid


On Aug. 28, 2013, 7:05 a.m., Tom Vincent Peters wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111662/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 7:05 a.m.)
> 
> 
> Review request for KDE Games and Matt Williams.
> 
> 
> Repository: ksquares
> 
> 
> Description
> -------
> 
> Hard AI for KSquares, 
> originally submitted about a year ago: https://svn.reviewboard.kde.org/r/6951/
> The new AI level is able to do hard hearted handouts and doublecrosses.
> This time there are only minimal UI changes that are required for the new AI level (and some credits).
> It seems that the medium ai uses hard hearted handouts more often than before (doesn't seem to influence the strength of the medium AI, see "Testing Done")
> 
> 
> Diffs
> -----
> 
>   src/aicontroller.h beaafa8 
>   src/aicontroller.cpp 0bff5e6 
>   src/ksquareswindow.cpp 092c795 
>   src/main.cpp 58184b6 
>   src/prefs_ai.ui 9774aed 
> 
> Diff: http://git.reviewboard.kde.org/r/111662/diff/
> 
> 
> Testing
> -------
> 
> 100 autoplay games medium against hard
> a lot of games against hard ai
> some games against medium ai
> Test whether medium ai code changed as a side effect of the new code: https://git.reviewboard.kde.org/r/111705/
> 
> 
> Thanks,
> 
> Tom Vincent Peters
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131015/ed3b5a20/attachment.html>