[Kde-games-devel] Review Request 113054: Finally, implement a way to not shoot at places the AI already knows there are no ships.

[Jaime Torres Amate]

> On Oct. 2, 2013, 6:32 p.m., Albert Astals Cid wrote:
> > src/aientity.cpp, line 47
> > <http://git.reviewboard.kde.org/r/113054/diff/2/?file=193628#file193628line47>
> >
> >     playerentity was KBS3 and this is KBS4, i've no clue what they mean, but just mentioning to make you double check :D

As I understand it. KBS3 is compatibility with version 3. KBS4 is compatibility with version 4. This feature was introduced in KBS4.


> On Oct. 2, 2013, 6:32 p.m., Albert Astals Cid wrote:
> > src/playerentity.cpp, line 110
> > <http://git.reviewboard.kde.org/r/113054/diff/2/?file=193629#file193629line110>
> >
> >     Why is this gone?

This does not make any sense (to me). An AI can mark the opposite field with hints where not to try, but why do that for a human player? I guess the human player should do that by him(her)self.


- Jaime Torres


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113054/#review41137
-----------------------------------------------------------


On Oct. 2, 2013, 4:44 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113054/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 4:44 p.m.)
> 
> 
> Review request for KDE Games and Roney Gomes.
> 
> 
> Bugs: 318594
>     http://bugs.kde.org/show_bug.cgi?id=318594
> 
> 
> Repository: knavalbattle
> 
> 
> Description
> -------
> 
> (the red spaces are already gone)
> Move the addBorder to the AI entity. When notify is called after a shoot, and an opponent ship is sunk, mark the surrounding cells as border, therefore, the AI will not try them in the future.
> Added a getter for the adjacent ships property.
> 
> 
> Diffs
> -----
> 
>   src/ai/smartai.cpp 37021a8 
>   src/aientity.cpp c8fa775 
>   src/playerentity.cpp 8c7bf16 
>   src/sea.h c68f348 
> 
> Diff: http://git.reviewboard.kde.org/r/113054/diff/
> 
> 
> Testing
> -------
> 
> played a lot against the AI, it does not use the cells around a sunk ship.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131002/d7fd838d/attachment.html>