[Kde-games-devel] Review Request 113929: No in-game action message pop-ups anymore.

Pierre Ducroquet pinaraf at gmail.com
Tue Nov 26 21:37:57 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113929/#review44547
-----------------------------------------------------------


The message view improvement is good, but disabling all dialogs makes the game harder to follow, maybe some other solutions must be found there (passive but visible notifications, highlights on the map, simple all-in-one popup…)

- Pierre Ducroquet


On Nov. 24, 2013, 9:04 p.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113929/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2013, 9:04 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 298274
>     http://bugs.kde.org/show_bug.cgi?id=298274
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> Every action involving a human player was shown as a separate message box. With standing orders and a larger board, this led to many annoying message boxes each turn, totally removing the flow out of the game.
> 
> This patch completely removes the message boxes from in-game. All messages are - as before - logged to the messages dock. They now are grouped by turn number for faster visual recognition.
> 
> 
> Diffs
> -----
> 
>   gameview.h 3678226 
>   gameview.cc c68e988 
> 
> Diff: http://git.reviewboard.kde.org/r/113929/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131126/c7c9be72/attachment.html>


More information about the kde-games-devel mailing list