[Kde-games-devel] Review Request 113929: No in-game action message pop-ups anymore.

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113929/
-----------------------------------------------------------

(Updated Nov. 24, 2013, 9:04 p.m.)


Review request for KDE Games.


Changes
-------

This is just an updated patch against current master.

Some unused code still is present. Once this approach to get rid of the message pop-ups and to structure the information in the messages dock is accepted, I plan to convert the messages docks to a tree widget. Each item there needs to understand what it is, rather than just being a HTML-formatted line, so that when clicking on it, the planet involved can be highlighted.


Bugs: 298274
    http://bugs.kde.org/show_bug.cgi?id=298274


Repository: konquest


Description
-------

Every action involving a human player was shown as a separate message box. With standing orders and a larger board, this led to many annoying message boxes each turn, totally removing the flow out of the game.

This patch completely removes the message boxes from in-game. All messages are - as before - logged to the messages dock. They now are grouped by turn number for faster visual recognition.


Diffs (updated)
-----

  gameview.h 3678226 
  gameview.cc c68e988 

Diff: http://git.reviewboard.kde.org/r/113929/diff/


Testing
-------


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131124/9ec15602/attachment-0001.html>