[Kde-games-devel] Review Request 113916: Choose player type when adding new player in Konquest

[Alexander Schuch]

> On Nov. 21, 2013, 2:34 a.m., Alexander Schuch wrote:
> > dialogs/newgamedlg.cc, line 206
> > <http://git.reviewboard.kde.org/r/113916/diff/1/?file=214717#file214717line206>
> >
> >     This variable is not used anywhere.

I fixed it myself and committed it to master. But I seem unable to close this issue here.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113916/#review44085
-----------------------------------------------------------


On Nov. 19, 2013, 11:47 p.m., Pierre Ducroquet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113916/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 11:47 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> Change the add player button in new game dialog to a popup based button, in order to immediately choose the player type, and thus make it obvious to anyone.
> 
> 
> Diffs
> -----
> 
>   dialogs/newgamedlg.h bd7333b74efcd2491d79551ac0faf98be2c84425 
>   dialogs/newgamedlg.cc 114c817147b14657990655d9ab669398471d0952 
> 
> Diff: http://git.reviewboard.kde.org/r/113916/diff/
> 
> 
> Testing
> -------
> 
> Start new game, add/remove/change users.
> 
> 
> Thanks,
> 
> Pierre Ducroquet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131124/640abce1/attachment.html>