[Kde-games-devel] Review Request 113916: Choose player type when adding new player in Konquest

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113916/#review44085
-----------------------------------------------------------



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/113916/#comment31596>

    This variable is not used anywhere.



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/113916/#comment31597>

    With this change there now are two concepts about player selection. To edit an already added player, a drop down is used. To add a new player, a menu button is used.
    
    And regarding bug 327081 (https://bugs.kde.org/show_bug.cgi?id=327081), can you replace the drop down for changing the controller of already added players with an edit menu button? That way, only one concept will be in action again.



dialogs/newgamedlg.cc
<http://git.reviewboard.kde.org/r/113916/#comment31598>

    Now, it takes two clicks and some aim to add another player. Isn't it possible to add the last player (as it was before) if the menu is not used, but additionally allow a menu to be used in order to select a player?


- Alexander Schuch


On Nov. 19, 2013, 11:47 p.m., Pierre Ducroquet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113916/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 11:47 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> Change the add player button in new game dialog to a popup based button, in order to immediately choose the player type, and thus make it obvious to anyone.
> 
> 
> Diffs
> -----
> 
>   dialogs/newgamedlg.h bd7333b74efcd2491d79551ac0faf98be2c84425 
>   dialogs/newgamedlg.cc 114c817147b14657990655d9ab669398471d0952 
> 
> Diff: http://git.reviewboard.kde.org/r/113916/diff/
> 
> 
> Testing
> -------
> 
> Start new game, add/remove/change users.
> 
> 
> Thanks,
> 
> Pierre Ducroquet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131121/5d4f06e2/attachment.html>