[Kde-games-devel] Review Request 113782: Make "current standings" dialogue a dockable widget.

[Alexander Schuch]

> On Nov. 11, 2013, 12:48 p.m., Nemanja Hirsl wrote:
> > At the end of the game there is "Final standings" modal dialog which contains the same info as "Standings" dialog. Is there a way to use just one and to end game in different way?

I do not fully understand what you mean.

>From a code point of view, there only is one widget for the standings overview. It is used in the dock and in the dialogue.

Winning the game (or losing it) is a singular event as the actual game ceases to exist. This deserves modal information. Maybe the standings dock could be closed. But this might be confusing if just the standings dock closes but the messages dock stays open. Closing the messages dock as well might hide information the player is interested in. So in short, I do not fully understand what you mean and about what you could mean, I have no better idea right now.


> On Nov. 11, 2013, 12:48 p.m., Nemanja Hirsl wrote:
> > mainwin.h, line 26
> > <http://git.reviewboard.kde.org/r/113782/diff/1/?file=212361#file212361line26>
> >
> >     You already have forward declaration below. Why include?

Oh. I think this is a left over from "before I learned".


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113782/#review43422
-----------------------------------------------------------


On Nov. 10, 2013, 3:33 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113782/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 3:33 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The dialogue "current standings" is replaced by a dockable widget. This way the player is able to see the standings all the time without the need to open/close the dialogue at the beginning of each turn.
> 
> The dockable widget can also be made floating, so it can be used almost the same as the modal dialogue before.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b321ad 
>   dialogs/scoredlg.h bda18a5 
>   dialogs/scoredlg.cc 5e66cd4 
>   gameview.h 47b9463 
>   gameview.cc 2505994 
>   konquestui.rc a99d39d 
>   mainwin.h c50ea80 
>   mainwin.cc 6f2a70d 
>   view/standingswidget.h PRE-CREATION 
>   view/standingswidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113782/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131116/0cac3ee1/attachment.html>