[Kde-games-devel] Review Request 113782: Make "current standings" dialogue a dockable widget.

[Nemanja Hirsl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113782/#review43422
-----------------------------------------------------------


At the end of the game there is "Final standings" modal dialog which contains the same info as "Standings" dialog. Is there a way to use just one and to end game in different way? 


mainwin.h
<http://git.reviewboard.kde.org/r/113782/#comment31266>

    You already have forward declaration below. Why include?


- Nemanja Hirsl


On Nov. 10, 2013, 3:33 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113782/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 3:33 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The dialogue "current standings" is replaced by a dockable widget. This way the player is able to see the standings all the time without the need to open/close the dialogue at the beginning of each turn.
> 
> The dockable widget can also be made floating, so it can be used almost the same as the modal dialogue before.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b321ad 
>   dialogs/scoredlg.h bda18a5 
>   dialogs/scoredlg.cc 5e66cd4 
>   gameview.h 47b9463 
>   gameview.cc 2505994 
>   konquestui.rc a99d39d 
>   mainwin.h c50ea80 
>   mainwin.cc 6f2a70d 
>   view/standingswidget.h PRE-CREATION 
>   view/standingswidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113782/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131111/39d0c32c/attachment.html>