[Kde-games-devel] Review Request 113596: Make messages list dockable.

[Albert Astals Cid]

> On Nov. 9, 2013, 11:07 p.m., Albert Astals Cid wrote:
> > mainwin.cc, line 114
> > <http://git.reviewboard.kde.org/r/113596/diff/3/?file=212273#file212273line114>
> >
> >     What you need the object name for?
> 
> Alexander Schuch wrote:
>     QMainWindow::saveState(): 'objectName' not set for QDockWidget 0x852ab0 'Messages;
>     
>     Without an object name, I get the message above during runtime (Qt 4.8.4). This is not required anymore for later versions?

Ok, I didn't remember it was needed and since I could not apply the patch, could test it either. It's obviously right with the setObjectName.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113596/#review43313
-----------------------------------------------------------


On Nov. 10, 2013, 2:34 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113596/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 2:34 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The messages list was always visible and always at the bottom of the game
> view. It now is a dockable widget which can be moved to any edge of the
> window or even made floating, or closed altogether.
> 
> 
> Diffs
> -----
> 
>   Konquest.cc fdabc5b 
>   gameview.h 47b9463 
>   gameview.cc 2505994 
>   konquestui.rc a99d39d 
>   mainwin.h c50ea80 
>   mainwin.cc 6f2a70d 
> 
> Diff: http://git.reviewboard.kde.org/r/113596/diff/
> 
> 
> Testing
> -------
> 
> I did the main testing with a further (not yet published) patch which makes the standings overview a dock as well. Messages dock and standings dock play together nicely, even when tabbed in one dock. Fixes of issues noticed during testing there are backported to this patch now.
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131111/58c46184/attachment-0001.html>