[Kde-games-devel] Review Request 113596: Make messages list dockable.

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113596/
-----------------------------------------------------------

(Updated Nov. 10, 2013, 2:34 a.m.)


Review request for KDE Games.


Changes
-------

Use forward declarations where possible to speed up compilation.


Repository: konquest


Description
-------

The messages list was always visible and always at the bottom of the game
view. It now is a dockable widget which can be moved to any edge of the
window or even made floating, or closed altogether.


Diffs (updated)
-----

  Konquest.cc fdabc5b 
  gameview.h 47b9463 
  gameview.cc 2505994 
  konquestui.rc a99d39d 
  mainwin.h c50ea80 
  mainwin.cc 6f2a70d 

Diff: http://git.reviewboard.kde.org/r/113596/diff/


Testing
-------

I did the main testing with a further (not yet published) patch which makes the standings overview a dock as well. Messages dock and standings dock play together nicely, even when tabbed in one dock. Fixes of issues noticed during testing there are backported to this patch now.


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131110/61367e1b/attachment-0001.html>