[Kde-games-devel] Review Request 113512: Animation fix for KReversi

[Denis Kuplyakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113512/
-----------------------------------------------------------

(Updated Nov. 5, 2013, 4:56 p.m.)


Review request for KDE Games, Albert Astals Cid and Viranch Mehta.


Changes
-------

Fixed many aspects about animation
    
    1) I am using QTimer::setInterval, QTimer::setSingleShot
     and QTimer::start instead of static singleShot method to
     control user moves during animation.
    2) Animation is sequental now
    3) Added empty transition to not animate just placed white chip


Repository: kreversi


Description
-------

This fixes animation for KReversi. Now chips are turning "as wave" from player's move position.


Diffs (updated)
-----

  kreversiview.h 2356fe7 
  kreversiview.cpp b7a9ddf 
  qml/Board.qml 60c6814 
  qml/Cell.qml 2007265 
  qml/Chip.qml 78d65bb 
  qml/Table.qml 158ba65 

Diff: http://git.reviewboard.kde.org/r/113512/diff/


Testing
-------

I have tested it a bit, seems to work.


Thanks,

Denis Kuplyakov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131105/a38da1b9/attachment.html>