[Kde-games-devel] Review Request 113596: DRAFT: Make messages list dockable.

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113596/
-----------------------------------------------------------

Review request for KDE Games.


Repository: konquest


Description
-------

The messages list was always visible and always at the bottom of the game
view. It now is a dockable widget which can be moved to any edge of the
window or even made floating, or closed altogether.


Diffs
-----

  Konquest.cc fdabc5b 
  gameview.h 47b9463 
  gameview.cc a01bfde 
  konquestui.rc cd43d33 
  mainwin.h d72fd46 
  mainwin.cc 929c61d 

Diff: http://git.reviewboard.kde.org/r/113596/diff/


Testing
-------

During testing I noticed two things which I like to fix but do not yet know how:

1) The splash screen should not contain the message dock. This is done by hiding the dock and disabling the view menu to show it again. However, when right-clicking the menu bar, a popup is shown which allows showing/hiding the toolbar and showing/hiding the messages dock. Should we not care and even show the messages dock on the splash screen (when enabled)? Or should we care and disable that menu item there - how?

2) Konquest always resized the main window to 600x650 on start. This is annoying as KDE automatically stores the status and size of the docks and this does not play well together with a forced application window resize. I removed the forced resize and this works well, with the only exception that when starting Konquest without any configuration (removed ~/.kde/share/config/konquestrc), the vertical size is very small - the first impression of a new user might be "buggy". So, how to approach this situation? Maybe just use a setMinimumSize() of 600x650? Or is it possible to detect that a previous window configuration has been loaded and only resize to 600x650 if it is the first-time use of Konquest? This seems to be a standard problem - is there a standard solution?


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131103/099b9bce/attachment.html>