[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

Matthew Scheirer matt.scheirer at gmail.com
Thu May 30 23:26:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110650/
-----------------------------------------------------------

(Updated May 30, 2013, 11:26 p.m.)


Review request for KDE Games.


Changes
-------

Uses KToggleAction to track menubar visibility instead of the menubar itself. (so the ToggleAction reflects menubar->isVisible). Now has to set the ToggleAction on startup to whether the menubar is visible.


Description
-------

Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.


This addresses bug 320269.
    http://bugs.kde.org/show_bug.cgi?id=320269


Diffs (updated)
-----

  mainwindow.cpp a42f8ef 
  mainwindow.h c9cbeae 

Diff: http://git.reviewboard.kde.org/r/110650/diff/


Testing
-------

Shortcut works, settings preserved across multiple sessions.


Thanks,

Matthew Scheirer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130530/c76cad79/attachment.html>


More information about the kde-games-devel mailing list