[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110650/#review33492
-----------------------------------------------------------


You fix one thing and break another, now the checked status of the action is basically random and can't know if checked means menubar is shown or not (other than looking at the menubar :D) and by doing Ctrl+m, Cancel you can have the entry both checked and unchecked.

- Albert Astals Cid


On May 30, 2013, 12:07 a.m., Matthew Scheirer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110650/
> -----------------------------------------------------------
> 
> (Updated May 30, 2013, 12:07 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.
> 
> 
> This addresses bug 320269.
>     http://bugs.kde.org/show_bug.cgi?id=320269
> 
> 
> Diffs
> -----
> 
>   mainwindow.h c9cbeae 
>   mainwindow.cpp a42f8ef 
> 
> Diff: http://git.reviewboard.kde.org/r/110650/diff/
> 
> 
> Testing
> -------
> 
> Shortcut works, settings preserved across multiple sessions.
> 
> 
> Thanks,
> 
> Matthew Scheirer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130530/94391325/attachment.html>