[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

[Matthew Scheirer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110650/
-----------------------------------------------------------

(Updated May 30, 2013, 12:02 a.m.)


Review request for KDE Games.


Changes
-------

Didn't know KToggleAction's checked value isn't preserved across application sessions. Fixed it to do the conditional on menu->isHidden(), which is preserved, which also let me remove that dangling else condition (which was also caused by the lack of persistent state in the ToggleAction). I tested it with the toggle on and off, across sessions, the conditional properly fires on the menubars state now.


Description
-------

Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.


This addresses bug 320269.
    http://bugs.kde.org/show_bug.cgi?id=320269


Diffs (updated)
-----

  mainwindow.h c9cbeae 
  mainwindow.cpp a42f8ef 

Diff: http://git.reviewboard.kde.org/r/110650/diff/


Testing
-------

Shortcut works, settings preserved across multiple sessions.


Thanks,

Matthew Scheirer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130530/00077bd9/attachment-0001.html>