[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

[Albert Astals Cid]

> On May 29, 2013, 9:54 p.m., Albert Astals Cid wrote:
> > Pressed Ctrl+m after restarting the game with the menubar hidden. Asks me if i want to hide the menubar.
> 
> Matthew Scheirer wrote:
>     I tried to reproduce this and even after resetting my kpatrc in my home dir it doesn't happen. It might be because I just renamed HideMenubarWarning to MenubarWarning because the way KMessageBox stores the background toggle is that it defaults to true and switches it false if the checkbox is set (and in nomenclature MenubarWarning=true should mean show the warning) so it would have regenerated a new entry in your kpatrc config with the updated diff.
>     
>     If you can reproduce it again, let me know what the value of MenubarWarning in your kpatrc is before and after. On my end that is enough to supress further notifications regardless of if the menu is shown or hidden on an application restart (it just stays false, and defaults True if the value was never set before).

rm kpatrc
start kpat
press ctrl+m
say continue
press alt+f4
start kpat (check menu is hidden)
press ctrl+m (get asked about hiding the menu)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110650/#review33385
-----------------------------------------------------------


On May 28, 2013, 11:03 p.m., Matthew Scheirer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110650/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 11:03 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.
> 
> 
> This addresses bug 320269.
>     http://bugs.kde.org/show_bug.cgi?id=320269
> 
> 
> Diffs
> -----
> 
>   mainwindow.h c9cbeae 
>   mainwindow.cpp a42f8ef 
> 
> Diff: http://git.reviewboard.kde.org/r/110650/diff/
> 
> 
> Testing
> -------
> 
> Shortcut works, settings preserved across multiple sessions.
> 
> 
> Thanks,
> 
> Matthew Scheirer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130529/ade8804d/attachment.html>