[Kde-games-devel] Review Request 109565: Bug 188413 - out-of-bounds array index when trying to generate solvable board

[Ian Simpson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109565/
-----------------------------------------------------------

(Updated March 21, 2013, 3:23 p.m.)


Review request for KDE Games.


Changes
-------

Changing the branch to qgraphic instead of master as part 1 of 2.

This fixes the cause of the crash, and the second hides the tiles if the game cannot be generated.


Description
-------

Added bounds checking in GameData::onlyFreeInLine()


This addresses bug 188413.
    http://bugs.kde.org/show_bug.cgi?id=188413


Diffs
-----

  GameData.cpp 3867b10 

Diff: http://git.reviewboard.kde.org/r/109565/diff/


Testing
-------

Successfully loaded the heart.layout attached by bug reporter.


Thanks,

Ian Simpson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130321/d4dadf77/attachment.html>